fix: update email validation

PR-URL: #15 Credit: @ Close: #15 Reviewed-by: @isaacs
npm · Oct 15, 2020 · c8a87da · 510sss · Oct 23, 2020 · c8a87da
1 parent cd75393
commit c8a87da
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/npm-user-validate.js b/npm-user-validate.js
@@ -11,6 +11,7 @@ var requirements = exports.requirements = {
   },
   password: {},
   email: {
+    length: 'Email length must be less then or equal to 254 characters long',
     valid: 'Email must be an email address'
   }
 }
@@ -45,7 +46,10 @@ function username (un) {
 }
 
 function email (em) {
-  if (!em.match(/^.+@.+\..+$/)) {
+  if (em.length > 254) {
+    return new Error(requirements.email.length)
+  }
+  if (!em.match(/^[^@]+@.+\..+$/)) {
     return new Error(requirements.email.valid)
   }
 

diff --git a/test/email.test.js b/test/email.test.js
@@ -7,6 +7,13 @@ test('email misses an @', function (t) {
   t.end()
 })
 
+test('email is longer then 254 characters', function (t) {
+  var str = '@'.repeat(255)
+  var err = v(str)
+  t.type(err, 'object')
+  t.end()
+})
+
 test('email misses a dot', function (t) {
   var err = v('name@domain')
   t.type(err, 'object')