fix: allow pre-release versions of npm and node

npm · Sep 30, 2019 · 893b181 · 893b181
1 parent ab92033
commit 893b181
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/index.js b/index.js
@@ -7,9 +7,10 @@ exports.checkEngine = checkEngine
 function checkEngine (target, npmVer, nodeVer, force, strict, cb) {
   var nodev = force ? null : nodeVer
   var eng = target.engines
+  var opt = { includePrerelease: true }
   if (!eng) return cb()
-  if (nodev && eng.node && !semver.satisfies(nodev, eng.node) ||
-      eng.npm && !semver.satisfies(npmVer, eng.npm)) {
+  if (nodev && eng.node && !semver.satisfies(nodev, eng.node, opt) ||
+      eng.npm && !semver.satisfies(npmVer, eng.npm, opt)) {
     var er = new Error(util.format('Unsupported engine for %s: wanted: %j (current: %j)',
       target._id, eng, {node: nodev, npm: npmVer}))
     er.code = 'ENOTSUP'

diff --git a/test/check-engine.js b/test/check-engine.js
@@ -60,3 +60,12 @@ test('no engine', function (t) {
     t.end()
   })
 })
+
+test('npm prerelease', function (t) {
+  var target = { engines: { node: '>=0.8', npm: '>=1.2.3' } }
+  c(target, '69.420.0-yolo', '69.420.0-yolo', true, true, function (err, warn) {
+    t.notOk(err, 'returns no error')
+    t.notOk(warn, 'returns no warning')
+    t.end()
+  })
+})