fix(license): don't fail when license is whitespace-only field (#93)

Fixes: pnpm/pnpm#1067
npm · Mar 7, 2018 · df8ea05 · df8ea05
1 parent 9948ecf
commit df8ea05
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/lib/fixer.js b/lib/fixer.js
@@ -299,7 +299,8 @@ var fixer = module.exports = {
     } else{
       if (
         typeof(data.license) !== 'string' ||
-        data.license.length < 1
+        data.license.length < 1 ||
+        data.license.trim() === ''
       ) {
         this.warn("invalidLicense")
       } else {

diff --git a/test/normalize.js b/test/normalize.js
@@ -156,6 +156,25 @@ tap.test("license field should be a valid SPDX expression", function(t) {
   t.end()
 })
 
+tap.test("don't fail when license is just a space", function(t) {
+  var warnings = []
+  function warn(w) {
+    warnings.push(w)
+  }
+  var a
+  normalize(a={
+    license: ' '
+  }, warn)
+
+  var expect =
+    [ warningMessages.missingDescription,
+      warningMessages.missingRepository,
+      warningMessages.missingReadme,
+      warningMessages.invalidLicense]
+  t.same(warnings, expect)
+  t.end()
+})
+
 tap.test("gist bugs url", function(t) {
   var d = {
     repository: "git@gist.github.com:123456.git"