fix: use hostname for socks agent #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
host was deprecated and removed in the next semver major
nlf
reviewed
Jun 1, 2022
| @@ -198,6 +198,9 @@ function getProxy (proxyUrl, opts, isHttps) { | |||
| return new HttpsProxyAgent(popts) | |||
| } | |||
| } else if (proxyUrl.protocol.startsWith('socks')) { | |||
| // socks-proxy-agent uses hostname not host | |||
| popts.hostname = popts.host | |||
| delete popts.host | |||
There was a problem hiding this comment.
are we removing host because it logs a warning if you pass both?
There was a problem hiding this comment.
I removed it to err on the side of explicitness. Renaming versus copying. Otherwise I would have just added hostname to popts. I don't really like that though, that feels like succeeding by coincidence for either agent type.
nlf
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
host was deprecated and removed in the next semver major