Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: npm/cacache
base: v17.0.6
Choose a base ref
...
head repository: npm/cacache
compare: v17.0.7
Choose a head ref
  • 3 commits
  • 7 files changed
  • 2 contributors

Commits on May 1, 2023

  1. fix: Trust the filesystem to move files 

    The original lib/util/move-file.js has gone through many iterations over
the last several years.  It no longer represents anything close to the
original intent.

Most of the functionality it was originally trying to work around is now
something that `@npmcli/fs#moveFile` does, and better.  Trying to move a
file by creating a hard link and unlinking the old file is an
optimization best left to the operating system when you ask it to move a
file.  In fact the `@npmcli/fs#moveFile` method tries a *rename* first,
which is the best choice all around.  It also supports an "overwrite:
false" flag so we can still error out if the destination already exists.

This PR removes all of the old legacy code.
    @wraithgar
    wraithgar committed May 1, 2023
    Configuration menu
    Copy the full SHA
    265e4ae View commit details
    Browse the repository at this point in the history

  2. deps: remove promise-inflight

    @wraithgar
    wraithgar committed May 1, 2023
    Configuration menu
    Copy the full SHA
    11fc035 View commit details
    Browse the repository at this point in the history

  3. chore: release 17.0.7

    @github-actions @wraithgar
    github-actions[bot] authored and wraithgar committed May 1, 2023
    Configuration menu
    Copy the full SHA
    07a8d39 View commit details
    Browse the repository at this point in the history