-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
2 changed files
with
34 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a0cab71
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sleep, delaying
npm install
for five seconds for advertising purposes, for all users, for every single build on CI, which a human never sees, is disgusting, and you should be ashamed of yourself.a0cab71
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FauxFaux I don't really see the problem here. Using Nodemailer is not mandatory in any way, it is my personal project that I have publicly and good willingly shared with anyone who wants to use it and that's about it, no liabilities involved. If you have any issues with current behaviour then either fork Nodemailer and remove the code you do not like or use an alternative like emailjs. It is from a different author, has more-or-less the same features and does not have any ads built in.
a0cab71
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I accept that you might want to put ads in, to try and benefit from the stuff you are providing, and we are using for free.
I do not accept that it is okay to delay our CI build by five seconds.