Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-gyp
base: 39ac2c135db8a9e62bf22f0c7a4469ae6c381325
Choose a base ref
...
head repository: nodejs/node-gyp
compare: 33391db3a0008eff8408890da6ab232f2f90fcab
Choose a head ref
  • 13 commits
  • 23 files changed
  • 8 contributors

Commits on Mar 13, 2023

  1. feat: Upgrade Python linting from flake8 to ruff (#2815)

    [Ruff](https://beta.ruff.rs/) supports [over 500 lint rules](https://beta.ruff.rs/docs/rules) including bandit, isort, pylint, pyupgrade, and flake8 plus its plugins and is written in Rust for speed.
    
    This GitHub Action will provide contributors with intuitive GitHub Annotations.
    
    ![image](https://user-images.githubusercontent.com/3709715/223758136-afc386d2-70aa-4eff-953a-2c2d82ceea23.png)
    
    The `Required` in the checks below should be:
    1. Removed from `flake8-annotation` and added to `ruff-annotation` which replaces it.
    2. Removed from `isort` and added to `ruff` which replaces it.
    cclauss committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    fc0ddc6 View commit details
    Browse the repository at this point in the history
  2. Improved advise on repacing node-sass with sass (#2758)

    * Improved advise on repacing node-sass with sass
    
    * Update README.md
    cclauss committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    41882a9 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2023

  1. chore: get update-gyp.py to work with Python >= v3.5 (#2826)

    * chore: get update-gyp.py to work with Python v3.9
    
    * Ruff ignore rule PLC1901
    
    ---------
    
    Co-authored-by: Christian Clauss <cclauss@me.com>
    rzhao271 and cclauss committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    337e8e6 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2023

  1. doc: Update README.md (#2822)

    Co-authored-by: Christian Clauss <cclauss@me.com>
    beliaev-maksim and cclauss committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    c7927e2 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2023

  1. update make-fetch-happen to 11.0.3 (#2796)

    http-cache-semantics 4.1.0 is vulnerable
    
    https://www.cve.org/CVERecord?id=CVE-2022-25881
    ravindraP20 committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    02480f6 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2023

  1. Configuration menu
    Copy the full SHA
    6f3c2d3 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2023

  1. feat: add support for native windows arm64 build tools

    Visual Studio 2022 17.4 adds a native C++ compiler for Windows on ARM.
    This allows arm64 devices to leverage native build tools, leading to
    a 35% (or more) speed increase.
    https://devblogs.microsoft.com/visualstudio/arm64-visual-studio-is-officially-here/
    
    Signed-off-by: Dennis Ameling <dennis@dennisameling.com>
    dennisameling authored and StefanStojanovic committed May 25, 2023
    Configuration menu
    Copy the full SHA
    bb76021 View commit details
    Browse the repository at this point in the history
  2. fix: extract tarball to temp directory on Windows (#2846)

    * fix: check for errors while extracting downloaded tarball
    
    Signed-off-by: David Sanders <dsanders11@ucsbalum.com>
    
    * test: parallel installs
    
    Signed-off-by: David Sanders <dsanders11@ucsbalum.com>
    
    * fix: extract tarball to temp directory on Windows
    
    Signed-off-by: David Sanders <dsanders11@ucsbalum.com>
    
    ---------
    
    Signed-off-by: David Sanders <dsanders11@ucsbalum.com>
    dsanders11 committed May 25, 2023
    Configuration menu
    Copy the full SHA
    aaa117c View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2023

  1. Migration from tap to mocha (#2851)

    * migrate from tap to mocha
    
    After make-fetch-happen update GitHub Actions started failing. Migrating
    from tap to mocha testing framework for GitHub Action stability.
    
    * write custom test reporter for more verbose output
    
    Implemented a simple custom mocha test reporter to replace the default
    one. Made test report more developer friendly.
    StefanStojanovic committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    5df2b72 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2023

  1. fix: log statement is for devDir not nodedir (#2840)

    Signed-off-by: David Sanders <dsanders11@ucsbalum.com>
    dsanders11 committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    55048f8 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. win,install: only download target_arch node.lib (#2857)

    Instead of downloading node.lib for all architectures, just download the
    one that will be needed. Install.js changed to enable downloading just
    node.lib for node versions that already have tarball downloaded and
    extracted. Not fetching lib now fails the installation. Increased
    installVersion because of the changes.
    
    Refs: #2847
    StefanStojanovic committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    7a3fe1c View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2023

  1. test: remove deprecated Node.js and Python (#2868)

    * test: remove deprecated node.js and python
    
    Removed Node.js v14.x and Python v3.7. Also added Node.js v20.x.
    
    * Update .github/workflows/tests.yml
    
    Co-authored-by: Christian Clauss <cclauss@me.com>
    
    ---------
    
    Co-authored-by: Christian Clauss <cclauss@me.com>
    StefanStojanovic and cclauss committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    a0b3d1c View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2023

  1. chore: release 9.4.0

    github-actions[bot] authored and rvagg committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    33391db View commit details
    Browse the repository at this point in the history