chore: fix deactivateAlarm

node-opcua · Jul 3, 2023 · bade5e2 · bade5e2
1 parent 6fe67f5
commit bade5e2
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/packages/node-opcua-address-space/source/loader/register_node_promoter.ts b/packages/node-opcua-address-space/source/loader/register_node_promoter.ts
@@ -3,10 +3,7 @@ import { UAObject, UAVariable } from "node-opcua-address-space-base";
 
 import { g_promotableObject, Promoter } from "./namespace_post_step";
 
-export function registerNodePromoter(
-    standardNodeId: number,
-    promoter: Promoter,
-    applyOnTypes = false
-): void {
-    g_promotableObject[resolveNodeId(standardNodeId).toString()] = { promoter, onInstanceOnly: applyOnTypes };
+export function registerNodePromoter(standardNodeId: number, promoter: Promoter, onInstanceOnly = false): void {
+
+    g_promotableObject[resolveNodeId(standardNodeId).toString()] = { promoter, onInstanceOnly };
 }
diff --git a/packages/node-opcua-address-space/src/alarms_and_conditions/ua_alarm_condition_impl.ts b/packages/node-opcua-address-space/src/alarms_and_conditions/ua_alarm_condition_impl.ts
@@ -201,6 +201,9 @@ export class UAAlarmConditionImpl extends UAAcknowledgeableConditionImpl impleme
 
     public deactivateAlarm(retain?: boolean): void {
         const branch = this.currentBranch();
+        if (!branch) {
+            return;
+        }
         branch.setRetain(retain === undefined ? true : retain);
         branch.setActiveState(false);
     }

diff --git a/...ode-opcua-address-space/src/alarms_and_conditions/ua_certificate_expiration_alarm_impl.ts b/...ode-opcua-address-space/src/alarms_and_conditions/ua_certificate_expiration_alarm_impl.ts
@@ -193,7 +193,7 @@ class UACertificateExpirationAlarmImpl extends UASystemOffNormalAlarmImpl implem
             this.expirationLimit.accessLevel = makeAccessLevelExFlag("CurrentRead | CurrentWrite");
             this.expirationLimit.userAccessLevel = makeAccessLevelExFlag("CurrentRead | CurrentWrite");
             this.expirationLimit.on("value_changed", (dataValue) => {
-                // make sure we re-evaluate the certificfate
+                // make sure we re-evaluate the certificate
                 const certificate = this.getCertificate();
                 this.setCertificate(certificate);
             });