fix types missing in ESM monorepos #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Aaah, interesting. I didn't know about that. Thanks! |
|
This is now live on npm in v6.5.2 - thanks again! |
|
worked like a charm, thanks! |
|
Sorry I didn't get time to investigate this issue, and thanks for sending in this fix @rafaelpimpa! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
What Does This PR Do?
Fixes types missing in ESM monorepos
Added
Add
typesto module exports: https://nodejs.org/api/packages.html#community-conditions-definitionsChecklist
npm test) pass.methods/classes/constants/types have been annotated with TSDoc comments.
added for the same.