Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
fixup publish workflow
add runs-on for publish job

also test on node 15.x
  • Loading branch information
nfriedly committed Jul 1, 2021
1 parent 83fc975 commit c256606
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 11 deletions.
28 changes: 19 additions & 9 deletions .github/workflows/publish.yml
Expand Up @@ -9,18 +9,28 @@ on:
- 'v*.*.*'

jobs:
build:
runs-on: [ubuntu-latest, windows-latest, macos-latest]
test:
strategy:
matrix:
node-version: [12.x, 14.x, 15.x]
os: [ubuntu-latest, macos-latest, windows-latest]
runs-on: ${{ matrix.os }}

steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: 12
- run: npm ci
- run: npm test
# this is needed because otherwise it converts LF to CRLF on windows and then the linter fails the build
- name: Disable git autocrlf
run: |
git config --global core.autocrlf false
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }} on ${{ matrix.os }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm ci
- run: npm test

publish-npm:
needs: build
needs: test
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Expand Up @@ -6,10 +6,10 @@ name: Node.js CI
on: [push, pull_request]

jobs:
build:
test:
strategy:
matrix:
node-version: [10.x, 12.x, 14.x]
node-version: [12.x, 14.x, 15.x]
os: [ubuntu-latest, macos-latest, windows-latest]
runs-on: ${{ matrix.os }}

Expand Down

0 comments on commit c256606

Please sign in to comment.