Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Joy][Textarea] Pass textarea props from componentsProps #34223

Merged
merged 4 commits into from Sep 9, 2022
Merged

[Joy][Textarea] Pass textarea props from componentsProps #34223

merged 4 commits into from Sep 9, 2022

Conversation

zignis
Copy link
Contributor

@zignis zignis commented Sep 8, 2022

Signed-off-by: VelociRaptor 77036902+HexM7@users.noreply.github.com

Fixes textarea props (minLength, maxLength, etc) not being passed to the native element.

Signed-off-by: VelociRaptor <77036902+HexM7@users.noreply.github.com>
@mui-bot
Copy link

mui-bot commented Sep 8, 2022

Details of bundle changes

Generated by 🚫 dangerJS against 3836305

@siriwatknp siriwatknp added bug 🐛 Something doesn't work PR: needs test The pull request can't be merged package: joy-ui Specific to @mui/joy labels Sep 8, 2022
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! one last thing, let's add a test for it.

@zignis zignis requested review from siriwatknp and removed request for danilo-leal September 8, 2022 05:49
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for your contribution! I hope you had a great experience with Joy UI, feedback very welcome.

@zignis
Copy link
Contributor Author

zignis commented Sep 8, 2022

👍 Thanks for your contribution! I hope you had a great experience with Joy UI, feedback very welcome.

Absolutely. Looking forward to make more contributions.

@ZeeshanTamboli ZeeshanTamboli removed the PR: needs test The pull request can't be merged label Sep 8, 2022
@siriwatknp siriwatknp merged commit 6a9ec13 into mui:master Sep 9, 2022
@zignis zignis deleted the patch-4 branch September 11, 2022 03:48
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work package: joy-ui Specific to @mui/joy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants