Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Joy UI] Add FormControl component #34187

Merged
merged 32 commits into from Sep 9, 2022
Merged

[Joy UI] Add FormControl component #34187

merged 32 commits into from Sep 9, 2022

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Sep 3, 2022 •
edited

Add FormControl similar to Material UI. I improve the DX a little bit when composing the FormLabel with other components.

It can be composed with:

  • Input
  • Textarea
  • Select
  • Checkbox
  • RadioGroup

It links the FormLabel and FormHelperText with the associated form element.

@siriwatknp siriwatknp added package: joy-ui Specific to @mui/joy component: FormControl The React component labels Sep 3, 2022
@mui-bot
Copy link

mui-bot commented Sep 3, 2022 •
edited

Details of bundle changes

@mui/joy: parsed: +0.75% , gzip: +0.80%

Generated by 🚫 dangerJS against b4d53bb

@siriwatknp siriwatknp marked this pull request as ready for review September 7, 2022 14:04
@danilo-leal danilo-leal changed the title [FormControl][Joy] Add new component [Joy UI] Add FormControl component Sep 8, 2022
danilo-leal
danilo-leal approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I wonder though if we should have a specific FormControl component case? I see how it could be redundant given we have the text field already.

@siriwatknp
Copy link
Member Author

Looking good! I wonder though if we should have a specific FormControl component case? I see how it could be redundant given we have the text field already.

I have an RFC about removing the TextField and leaning on FormControl instead. Let's discuss it in the RFC but this PR is not related to the discussion because FormControl is independent.

@siriwatknp siriwatknp merged commit 420e4a7 into mui:master Sep 9, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
@siriwatknp
[Joy UI] Add FormControl component (mui#34187)
d4b744b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danilo-leal danilo-leal danilo-leal approved these changes

Assignees
No one assigned
Labels
component: FormControl The React component package: joy-ui Specific to @mui/joy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@siriwatknp @mui-bot @danilo-leal