Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Timeline] Add left and right aligned timeline demos in docs #34156

Merged
merged 8 commits into from Sep 8, 2022
Merged

[Timeline] Add left and right aligned timeline demos in docs #34156

merged 8 commits into from Sep 8, 2022

Conversation

ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented Aug 31, 2022 •
edited

Closes #22278

I saw some traction on the issue and decided to add demos.

Preview: https://deploy-preview-34156--material-ui.netlify.app/material-ui/react-timeline/#alignment

@ZeeshanTamboli ZeeshanTamboli added docs Improvements or additions to the documentation component: timeline This is the name of the generic UI component, not the React module! labels Aug 31, 2022
@mui-bot
Copy link

mui-bot commented Aug 31, 2022 •
edited

No bundle size changes

Generated by 🚫 dangerJS against d529dd4

@ZeeshanTamboli ZeeshanTamboli changed the title [Timeline] Add demos in docs for left and right aligned timelines [Timeline] Add left and right aligned timelines demos in docs Aug 31, 2022
@ZeeshanTamboli ZeeshanTamboli changed the title [Timeline] Add left and right aligned timelines demos in docs [Timeline] Add left and right aligned timeline demos in docs Aug 31, 2022
@ZeeshanTamboli ZeeshanTamboli marked this pull request as ready for review August 31, 2022 13:14
samuelsycamore
samuelsycamore reviewed Aug 31, 2022
View reviewed changes
Copy link
Member

@samuelsycamore samuelsycamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Text looks good, just one tiny suggestion :)

docs/data/material/components/timeline/timeline.md Outdated Show resolved Hide resolved
@ZeeshanTamboli @samuelsycamore
Update docs/data/material/components/timeline/timeline.md
9a2a822 
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
siriwatknp
siriwatknp reviewed Sep 7, 2022
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Love the demos!

danilo-leal
danilo-leal reviewed Sep 7, 2022
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Hope this helps folks who were struggling with this.

docs/data/material/components/timeline/timeline.md Outdated Show resolved Hide resolved
docs/data/material/components/timeline/timeline.md Outdated Show resolved Hide resolved
docs/data/material/components/timeline/timeline.md Outdated Show resolved Hide resolved
danilo-leal
danilo-leal approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! 👌

@ZeeshanTamboli ZeeshanTamboli merged commit 0189797 into mui:master Sep 8, 2022
@ZeeshanTamboli ZeeshanTamboli deleted the issue/22278-align-timeline-default branch September 8, 2022 06:30
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
@ZeeshanTamboli @samuelsycamore
[Timeline] Add left and right aligned timeline demos in docs (mui#34156)
5e5a408 
* add demos

* update code

* Update docs/data/material/components/timeline/timeline.md

Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>

* Jun's review - update demos

* Danilo's review - update docs

Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danilo-leal danilo-leal danilo-leal approved these changes

@mnajdova mnajdova Awaiting requested review from mnajdova

@samuelsycamore samuelsycamore Awaiting requested review from samuelsycamore

@siriwatknp siriwatknp Awaiting requested review from siriwatknp

Assignees
No one assigned
Labels
component: timeline This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to align Timeline to the left by default?
5 participants
@ZeeshanTamboli @mui-bot @siriwatknp @danilo-leal @samuelsycamore