Revert "[core] Replace getInitialProps with getStaticProps"
#33991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2b2b9c4.
mnajdova
added
docs
michaldudak
approved these changes
Aug 22, 2022
mnajdova
deleted the
revert-33684-docs/replace-getInitialProps-with-getStaticProps
branch
2 tasks
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #33684.
The PR broke the SEO structure when it comes to the translations. For example, the page https://mui.com/material-ui/api/table-pagination/ says:
But this page is a 404 https://mui.com/zh/material-ui/api/table-pagination/. Chinese users will directly get a 404. The Google Search console started to raise flags about it. The root problem might be covered in vercel/next.js#15315 (comment).