Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Joy] Add missing global exports #33982

Merged
merged 2 commits into from Aug 22, 2022

Conversation

tomasz-sodzawiczny
Copy link
Contributor

@tomasz-sodzawiczny tomasz-sodzawiczny commented Aug 18, 2022

I noticed that some of the Components are not re-exported from @mui/joy.

@mui-bot
Copy link

mui-bot commented Aug 18, 2022

Details of bundle changes

@mui/joy: parsed: +11.35% , gzip: +9.78%

Generated by 🚫 dangerJS against abd70bc

@siriwatknp
Copy link
Member

@tomasz-sodzawiczny First of all, really appreciate the fix and the proposal script. But to make it easier, let's split them so that we can merge the fix.

This PR should be just the fix (remove the script). For the script, I propose that you create an issue first describing the intention so that other team members and the community can comment. Later on, if we decided to move forward it will be another PR.

Is this sound good to you?

@tomasz-sodzawiczny
Copy link
Contributor Author

@tomasz-sodzawiczny First of all, really appreciate the fix and the proposal script. But to make it easier, let's split them so that we can merge the fix.

Done. I put sorting the imports and adding new ones in separate commits, if that helps with reviewing the change.

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩 Thanks for your first contribution!

@hbjORbj hbjORbj added the package: joy-ui Specific to @mui/joy label Aug 22, 2022
@hbjORbj hbjORbj merged commit e978474 into mui:master Aug 22, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: joy-ui Specific to @mui/joy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants