Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Add Icons8 gold sponsor #33978

Merged
merged 3 commits into from Aug 19, 2022

Conversation

michaldudak
Copy link
Member

@michaldudak michaldudak commented Aug 18, 2022

Added Icons8 sponsor to the readme and Backers page.

Preview: https://deploy-preview-33978--material-ui.netlify.app/

@michaldudak michaldudak added the website Pages that are not documentation-related, marketing-focused. label Aug 18, 2022
@mui-bot
Copy link

mui-bot commented Aug 18, 2022

No bundle size changes

Generated by 🚫 dangerJS against e7cb456

@@ -139,6 +139,7 @@ via [OpenCollective](https://opencollective.com/mui) or via [Patreon](https://ww
<a href="https://megafamous.com/?utm_source=MUI&utm_medium=referral&utm_content=readme" rel="noopener sponsored" target="_blank"><img height="96" width="96" src="https://mui.com/static/sponsors/megafamous.png" alt="megafamous.com" title="The best place to buy Instagram followers & likes." loading="lazy" /></a>
<a href="https://www.dialmycalls.com/?utm_source=MUI&utm_medium=referral&utm_content=readme" rel="noopener sponsored" target="_blank"><img height="96" width="96" src="https://images.opencollective.com/dialmycalls/f5ae9ab/avatar/192.png" alt="dialmycalls.com" title="Send text messages, calls & emails to thousands with ease." loading="lazy" /></a>
<a href="https://goread.io/?utm_source=MUI&utm_medium=referral&utm_content=readme" rel="noopener sponsored" target="_blank"><img height="96" width="96" src="https://images.opencollective.com/goread_io/eb6337d/logo/192.png" alt="goread.io" title="Instagram followers, likes, power likes, views, comments, saves in minutes." loading="lazy" /></a>
<a href="https://icons8.com?utm_source=MUI&utm_medium=referral&utm_content=readme" rel="noopener sponsored" target="_blank"><img height="96" width="96" src="https://images.opencollective.com/icons8/7fa1641/logo/192.png" alt="Icons8" title="We provide the neat icons, photos, illustrations, and music. Developers, use our API to insert all the content we have into your apps." loading="lazy"></a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also add it under the Gold sponsors on the Landing page :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed :) It's updated now.

Copy link
Member

@mbrookes mbrookes Aug 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did the description originate? I'm wondering if we should improve the English:

Suggested change
<a href="https://icons8.com?utm_source=MUI&utm_medium=referral&utm_content=readme" rel="noopener sponsored" target="_blank"><img height="96" width="96" src="https://images.opencollective.com/icons8/7fa1641/logo/192.png" alt="Icons8" title="We provide the neat icons, photos, illustrations, and music. Developers, use our API to insert all the content we have into your apps." loading="lazy"></a>
<a href="https://icons8.com?utm_source=MUI&utm_medium=referral&utm_content=readme" rel="noopener sponsored" target="_blank"><img height="96" width="96" src="https://images.opencollective.com/icons8/7fa1641/logo/192.png" alt="Icons8" title="We provide neat icons, photos, illustrations, and music. Developers, use our API to insert any of our content into your app." loading="lazy"></a>

Or use the meta description from their website instead:

"Download design elements for free: icons, photos, vector illustrations, and music for your videos. All assets made by designers for consistent quality."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did the description originate?

@mbrookes from https://opencollective.com/icons8

Screenshot 2022-08-21 at 23 17 54

Since it's a title, it's hidden, I would ignore this, not enough time for going this far :)

Copy link
Member

@mbrookes mbrookes Aug 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's a matter of personal pride. Having poor English on our home page (hidden or not) reflects badly on us, as with that in our documentation.

@michaldudak michaldudak merged commit 6ba3522 into mui:master Aug 19, 2022
@michaldudak michaldudak deleted the add-icons8-sponsor branch August 19, 2022 10:14
@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 21, 2022

I have pushed an extra commit to fix the regression from what seems to be the initial intent of @danilo-leal from a year ago https://www.figma.com/file/4uv2dT18rXJPZBbrbpw61q/Marketing-site?node-id=3224%3A11442: maximum two lines per sponsors descriptions. It feels better 😌

Screenshot 2022-08-21 at 23 15 49

https://deploy-preview-33978--material-ui.netlify.app/

darktasevski pushed a commit to darktasevski/material-ui that referenced this pull request Aug 22, 2022
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants