Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IconButton] Fix hover effect when CSS Variables are enabled #33971

Merged
merged 1 commit into from Aug 22, 2022

Conversation

TheUnlocked
Copy link
Contributor

A typo in the IconButton styling was preventing the hover effect from appearing when using CssVarsProvider. This fixes it.

@mui-bot
Copy link

mui-bot commented Aug 17, 2022

Details of bundle changes

Generated by 🚫 dangerJS against afbb3c8

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice catch! thanks for your first contribution, looking forward for the next one.

@hbjORbj hbjORbj added the component: icon button This is the name of the generic UI component, not the React module! label Aug 22, 2022
@siriwatknp siriwatknp added the bug 🐛 Something doesn't work label Aug 22, 2022
@hbjORbj hbjORbj merged commit 84c0837 into mui:master Aug 22, 2022
@TheUnlocked TheUnlocked deleted the fix-icon-button-hover branch August 31, 2022 01:07
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: icon button This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants