Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Autocomplete] Fix keepMounted Popper prop not working #33957

Merged
merged 7 commits into from Aug 19, 2022
Merged

[Autocomplete] Fix keepMounted Popper prop not working #33957

merged 7 commits into from Aug 19, 2022

Conversation

ZeeshanTamboli
Copy link
Member

Fixes #33881

@ZeeshanTamboli ZeeshanTamboli marked this pull request as ready for review August 17, 2022 05:09
@ZeeshanTamboli ZeeshanTamboli added bug 🐛 Something doesn't work component: autocomplete This is the name of the generic UI component, not the React module! labels Aug 17, 2022
@mui-bot
Copy link

mui-bot commented Aug 17, 2022 •
edited

Details of bundle changes

Generated by 🚫 dangerJS against ffd8860

siriwatknp
siriwatknp approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @ZeeshanTamboli

@ZeeshanTamboli ZeeshanTamboli merged commit 26dd510 into mui:master Aug 19, 2022
@ZeeshanTamboli ZeeshanTamboli deleted the issue/33881-autocomplete-keepMounted-popper-prop branch August 19, 2022 05:18
darktasevski pushed a commit to darktasevski/material-ui that referenced this pull request Aug 22, 2022
@ZeeshanTamboli @darktasevski
[Autocomplete] Fix keepMounted Popper prop not working (mui#33957)
490d051 
* add test

* add logic

* update test description

* prettier

* remove popupOpen check in width style
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
@ZeeshanTamboli
[Autocomplete] Fix keepMounted Popper prop not working (mui#33957)
9a6c9b9 
* add test

* add logic

* update test description

* prettier

* remove popupOpen check in width style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

@mnajdova mnajdova Awaiting requested review from mnajdova

@michaldudak michaldudak Awaiting requested review from michaldudak

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: autocomplete This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Autocomplete: keepMounted prop not working
3 participants
@ZeeshanTamboli @mui-bot @siriwatknp