Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ListItemText] Fix variant mapping in primaryTypography #33880

Merged
merged 6 commits into from Sep 8, 2022

Conversation

iamxukai
Copy link
Contributor

@iamxukai iamxukai commented Aug 10, 2022

fixes #33255

Codesandboxes

before
after

@mui-bot
Copy link

mui-bot commented Aug 10, 2022

Details of bundle changes

Generated by 🚫 dangerJS against 69e7498

@iamxukai iamxukai changed the title [ListItemText] fix variant mapping [ListItemText] Fix variant mapping Aug 10, 2022
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic looks good to me. Let's see what the MUI team says.

@ZeeshanTamboli ZeeshanTamboli added bug 🐛 Something doesn't work component: list This is the name of the generic UI component, not the React module! labels Aug 10, 2022
@ZeeshanTamboli ZeeshanTamboli changed the title [ListItemText] Fix variant mapping [ListItemText] Fix variant mapping in primaryTypography Aug 10, 2022
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Thanks for your contribution.

@ZeeshanTamboli ZeeshanTamboli merged commit 7bff521 into mui:master Sep 8, 2022
@ImCheesecake
Copy link

Amazing! Thank you for this @iamxukai! I hope it fixes my problem 😄

daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
* [ListItemText] fix variant mapping

* prettier

* improve readability in test

Co-authored-by: ZeeshanTamboli <zeeshan.tamboli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: list This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ListItemText] primaryTypographyProps doesn't include variantMapping
5 participants