New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(NODE-5771): improve new connection #3948
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
force-pushed
the
NODE-5771-perf-new-connection
branch
from
December 14, 2023 22:09
70d6ef8
to
bb83edb
Compare
nbbeeken
changed the title
chore(NODE-5771): benchmark new connection
perf(NODE-5771): improve new connection
Dec 15, 2023
durran
added
the
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
label
Dec 18, 2023
baileympearson
requested changes
Dec 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nothing blocking since I'm OOO starting tomorrow, just some comments
durran
requested changes
Dec 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question - did we also profile memory consumption?
durran
added
Team Review
Needs review from team
and removed
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
labels
Dec 19, 2023
durran
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
abortable
helper to not create a "done" signal, instead simplify the promise wrapping and abort listener removal to lower performance costIs there new documentation needed for these changes?
No.
What is the motivation for this change?
Improves the performance of the new connection layer to be on par with our existing connection layer. The major cost was constructing many AbortSignals, however, going back to using a stream to just collect chunks gets us within a margin of error of the old performance.
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript