feat(NODE-5717): make ExceededTimeLimit retryable reads error #3947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
added
the
Primary Review
W-A-James
previously approved these changes
Dec 11, 2023
W-A-James
added
Team Review
alenakhineika
dismissed stale reviews from aditi-khare-mongoDB and W-A-James
via
ca26998
W-A-James
approved these changes
Dec 11, 2023
aditi-khare-mongoDB
approved these changes
Dec 11, 2023
W-A-James
deleted the
NODE-5717-make-exceeded-time-limit-retryable-reads-error
branch
alenakhineika
changed the title
alenakhineika
changed the title
aditi-khare-mongoDB
pushed a commit
that referenced
this pull request
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Previously ExceededTimeLimit related only to retryable writes errors. Now it belongs both to RETRYABLE_WRITE_ERROR_CODES and RETRYABLE_READ_ERROR_CODES arrays.
Is there new documentation needed for these changes?
None
What is the motivation for this change?
NODE-5717
Release Highlight
ExceededTimeLimit was made a retryable reads error
The reading operations will be resumed after receiving the
ExceededTimeLimiterror.Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript