Make mobx-react compatible with TS 4.8+

[kubk]

Resolves: #3532

As @DanielSWolf wrote (thanks for that!): "This error occurs because TypeScript 4.8 is stricter than previous versions regarding unconstrained type parameters (see the blog entry announcing TypeScript 4.8)."

I confirm that adding constraint to the generic fixes the issue. Now the generic constraints are identical to IStoresToProps: https://github.com/mobxjs/mobx/blob/a39ce7fbe19f92348470ef71ad60555c37a5d5e9/packages/mobx-react/src/types/IStoresToProps.ts#L2+L6

I've chosen minor instead of patch because it's kinda BC break but at the same time it's a bugfix.

[changeset-bot]

🦋 Changeset detected

Latest commit: 13815ec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
mobx-react	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[DanielSWolf]

Regarding the failing tests: It seems to me that these tests have always been broken. TypeScript just didn't realize it until you fixed the types.

I've only skimmed the problems, but here are my best guesses:

• This line should probably read inject(() => ({}))( (note the extra parentheses).
• This line needs to explicitly specify the arrow function signature. This might work: const MainInjected = inject(({ store }: { store: { thing: number } }) => ({ thing: store.thing }))(Main)

[kubk]

@DanielSWolf Thank you for the suggestions 👍 The issue with explicit signature is that we create a BC break. It looks like previously TS could infer the type correctly. But since inject is deprecated we can ask people to avoid using it completely in case of issues.

[kubk]

@urugator The PR is ready to review 🙏