Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support out of bound indices on proxied arrays #3559

Merged
merged 11 commits into from Nov 1, 2022
Merged

Conversation

urugator
Copy link
Collaborator

See #3537

@changeset-bot
Copy link

changeset-bot bot commented Oct 31, 2022

🦋 Changeset detected

Latest commit: 487f1cb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mobx Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@mweststrate mweststrate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Left a minor nit.

packages/mobx/src/types/observablearray.ts Outdated Show resolved Hide resolved
@urugator
Copy link
Collaborator Author

urugator commented Nov 1, 2022

I forgot tests for legacy array are in v4 directory, so I've adjusted the tests accordingly.

@urugator urugator merged commit 8cf4784 into mobxjs:main Nov 1, 2022
@github-actions github-actions bot mentioned this pull request Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants