Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 3514: legacy array compat with Safari 9 #3516

Merged
merged 1 commit into from Sep 7, 2022
Merged

Conversation

urugator
Copy link
Collaborator

@urugator urugator commented Sep 5, 2022

Reintroduced workaround from mobx < 6.

Did not test as I don't have a means to do so.

Fixes #3514

@changeset-bot
Copy link

changeset-bot bot commented Sep 5, 2022

🦋 Changeset detected

Latest commit: 37c1cf0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mobx Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@mweststrate mweststrate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was part of just a clean up, assuming we wouldn't run anymore on that old Safaris

@urugator urugator merged commit 7260cd4 into mobxjs:main Sep 7, 2022
@github-actions github-actions bot mentioned this pull request Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobx6 array index assignment does not work in Safari
2 participants