common: Collect architecture as a common property

microsoft · Nov 18, 2021 · 4d7a45b · 4d7a45b
1 parent bdbab89
commit 4d7a45b
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 3 deletions.
diff --git a/src/browser/telemetryReporter.ts b/src/browser/telemetryReporter.ts
@@ -68,6 +68,10 @@ export default class TelemetryReporter extends BaseTelemetryReporter {
 		if (key && key.indexOf("AIF-") === 0) {
 			firstParty = true;
 		}
-		super(extensionId, extensionVersion, appender, { release: navigator.appVersion, platform: "web" }, firstParty);
+		super(extensionId, extensionVersion, appender, {
+			release: navigator.appVersion,
+			platform: "web",
+			architecture: "web",
+		}, firstParty);
 	}
 }
diff --git a/src/common/baseTelemetryReporter.ts b/src/common/baseTelemetryReporter.ts
@@ -28,7 +28,7 @@ export class BaseTelemetryReporter {
 		private extensionId: string,
 		private extensionVersion: string,
 		private telemetryAppender: ITelemetryAppender,
-		private osShim: { release: string, platform: string },
+		private osShim: { release: string, platform: string, architecture: string },
 		firstParty?: boolean
 	) {
 
@@ -132,6 +132,7 @@ export class BaseTelemetryReporter {
 	}
 
 	// __GDPR__COMMON__ "common.os" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
+	// __GDPR__COMMON__ "common.arch" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
 	// __GDPR__COMMON__ "common.platformversion" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
 	// __GDPR__COMMON__ "common.extname" : { "classification": "PublicNonPersonalData", "purpose": "FeatureInsight" }
 	// __GDPR__COMMON__ "common.extversion" : { "classification": "PublicNonPersonalData", "purpose": "FeatureInsight" }
@@ -145,6 +146,7 @@ export class BaseTelemetryReporter {
 	private getCommonProperties(): TelemetryEventProperties {
 		const commonProperties = Object.create(null);
 		commonProperties["common.os"] = this.osShim.platform;
+		commonProperties["common.arch"] = this.osShim.architecture;
 		commonProperties["common.platformversion"] = (this.osShim.release || "").replace(/^(\d+)(\.\d+)?(\.\d+)?(.*)/, "$1$2$3");
 		commonProperties["common.extname"] = this.extensionId;
 		commonProperties["common.extversion"] = this.extensionVersion;

diff --git a/src/node/telemetryReporter.ts b/src/node/telemetryReporter.ts
@@ -76,6 +76,10 @@ export default class TelemetryReporter extends BaseTelemetryReporter {
 		if (key && key.indexOf("AIF-") === 0) {
 			firstParty = true;
 		}
-		super(extensionId, extensionVersion, appender, { release: os.release(), platform: os.platform() }, firstParty);
+		super(extensionId, extensionVersion, appender, {
+			release: os.release(),
+			platform: os.platform(),
+			architecture: os.arch(),
+		}, firstParty);
 	}
 }