Skip to content

Commit

Permalink
Turn on linting (#116)
Browse files Browse the repository at this point in the history
Enable linting, this fails on node 6 and 8 because ESLint uses newer syntax that they don't understand. This is fine as we are dropping support for those versions since they are well beyond EOL.

Co-authored-by: Clay Jensen-Reimann <clayreimann@gmail.com>
  • Loading branch information
gabegorelick and clayreimann committed May 25, 2020
1 parent 663b967 commit e2d8232
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Expand Up @@ -3,7 +3,7 @@ node_js:
- "6"
- "8"
- "10"
script: npm test
script: npm run ci
deploy:
provider: npm
email: $NPM_EMAIL
Expand Down
3 changes: 2 additions & 1 deletion package.json
Expand Up @@ -4,7 +4,8 @@
"description": "A JUnit reporter for mocha.",
"main": "index.js",
"scripts": {
"lint": "./node_modules/.bin/eslint '*.js' 'test/**/*.js'; exit 0",
"ci": "npm run lint && npm run test",
"lint": "./node_modules/.bin/eslint '*.js' 'test/**/*.js'",
"test": "MOCHA_FILE=test/mocha.xml node_modules/.bin/mocha test --reporter=spec",
"tdd": "MOCHA_FILE=test/mocha.xml node_modules/.bin/mocha test --reporter=min --watch"
},
Expand Down
2 changes: 1 addition & 1 deletion test/mocha-junit-reporter-spec.js
Expand Up @@ -623,7 +623,7 @@ describe('mocha-junit-reporter', function() {
it('generates Jenkins compatible classnames and suite name', function() {
var reporter = configureReporter({jenkinsMode: true}, suites);

debug('testcase', reporter.suites[0].testsuite[1].testcase[0])
debug('testcase', reporter.suites[0].testsuite[1].testcase[0]);
expect(reporter.suites[0].testsuite[0]._attr.name).to.equal(suites[0].testsuite.title);
expect(reporter.suites[0].testsuite[1].testcase[0]._attr.name).to.equal(suites[0].pass[0].title);
expect(reporter.suites[0].testsuite[1].testcase[0]._attr.classname).to.equal(suites[0].testsuite.title);
Expand Down

0 comments on commit e2d8232

Please sign in to comment.