New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task lists are rendered even when GFM is disabled #1823
Labels
category: lists
good first issue
Something easy to get started with
L1 - broken
Valid usage causes incorrect output OR a crash AND there is no known workaround for the issue
released
Comments
UziTech
added
category: lists
L1 - broken
Valid usage causes incorrect output OR a crash AND there is no known workaround for the issue
labels
Nov 15, 2020
Thanks for reporting this. Can you create a PR to fix this? |
It looks like we just need to check for Lines 280 to 286 in da071c9
|
TheCloudlessSky
added a commit
to TheCloudlessSky/marked
that referenced
this issue
Nov 15, 2020
5 tasks
UziTech
added a commit
that referenced
this issue
Nov 19, 2020
* Fix #1823 - task lists are rendered even when GFM is disabled. * end file with a new line Co-authored-by: Tony Brix <tony@brix.ninja>
🎉 This issue has been resolved in version 1.2.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category: lists
good first issue
Something easy to get started with
L1 - broken
Valid usage causes incorrect output OR a crash AND there is no known workaround for the issue
released
Marked version:
1.2.3
Describe the bug
Even when
gfm: false
, task lists are rendered.To Reproduce
Steps to reproduce the behavior:
gfm: false
.Here's some demos:
Expected behavior
Task lists are only an extension of GFM, so I would expect the output to match CommonMark by using the
[ ]
as part of the rendered text:The text was updated successfully, but these errors were encountered: