Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: list alignment #1810

Merged
merged 6 commits into from Nov 4, 2020
Merged

fix: list alignment #1810

merged 6 commits into from Nov 4, 2020

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Nov 2, 2020 •
edited by joshbruce

Marked version: v1.2.2

Description

Fix list tests due to alignment and list style.

Fixes the following commonmark tests: 265, 267, 271, 280, 281

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

@vercel
Copy link

vercel bot commented Nov 2, 2020 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/markedjs/markedjs/p7nqu0e1n
✅ Preview: https://markedjs-git-space-list.markedjs.vercel.app

@UziTech UziTech mentioned this pull request Nov 3, 2020
Merged
styfle
styfle approved these changes Nov 4, 2020
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@joshbruce joshbruce merged commit 5f9cafd into markedjs:master Nov 4, 2020
@joshbruce
Copy link
Member

Might need some information or pointer to how we do release notes now. :)

joshbruce
joshbruce reviewed Nov 4, 2020
View reviewed changes
Copy link
Member

@joshbruce joshbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool

github-actions bot pushed a commit that referenced this pull request Nov 4, 2020
@semantic-release-bot
chore(release): 1.2.3 [skip ci]
ec2954e 
## [1.2.3](v1.2.2...v1.2.3) (2020-11-04)

### Bug Fixes

* list alignment ([#1810](#1810)) ([5f9cafd](5f9cafd))
@github-actions
Copy link

github-actions bot commented Nov 4, 2020

🎉 This PR is included in version 1.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@UziTech UziTech deleted the space-list branch November 6, 2020 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshbruce joshbruce joshbruce left review comments

@styfle styfle styfle approved these changes

@davisjam davisjam Awaiting requested review from davisjam

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unwanted nesting on ordered list Inserted <p> into <li> on different unordered lists
3 participants
@UziTech @joshbruce @styfle