MSVC: Fix warning C4133 on x64: "function": Incompatible types - from "unsigned long *" to "size_t *" #5317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethomson
reviewed
Dec 3, 2019
src/regexp.c
Outdated
| @@ -78,7 +78,7 @@ int git_regexp_search(const git_regexp *r, const char *string, size_t nmatches, | |||
| int git_regexp_compile(git_regexp *r, const char *pattern, int flags) | |||
| { | |||
| unsigned char errmsg[1024]; | |||
| unsigned long erroff; | |||
| size_t erroff; | |||
There was a problem hiding this comment.
Good catch. This should maybe be PCRE2_SIZE per the PCRE2 docs themselves. Will that always be size_t?
There was a problem hiding this comment.
It's hard-coded in pcre2.h, but I think PCRE2_SIZE is better...
… "unsigned long *" to "size_t *" Signed-off-by: Sven Strickroth <email@cs-ware.de>
|
Awesome. Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.