Skip to content

Commit

Permalink
chore: apply typo fixes (#3518)
Browse files Browse the repository at this point in the history
  • Loading branch information
JamesHenry committed Jan 31, 2023
1 parent 69a45de commit 86f8021
Show file tree
Hide file tree
Showing 9 changed files with 728 additions and 9 deletions.
4 changes: 2 additions & 2 deletions CHANGELOG.md
Expand Up @@ -78,7 +78,7 @@ As of version 6.0.0, Lerna will now delegate the implementation details of the `

If for some reason you wish to opt in to the legacy task-runner implementation details (powered by `p-map` and `p-queue`), you can do so by setting `"useNx": false` in your lerna.json. (Please let us know via a Github issue if you feel the need to do that, however, as in general the new task-runner should just work how you expect it to as a lerna user).

### Interactive configurtion for `lerna run` caching and task pipelines via the new `lerna add-caching` command
### Interactive configuration for `lerna run` caching and task pipelines via the new `lerna add-caching` command

When using the modern task-runner implementation described above, the way to get the most out of it is to tell it about the outputs of your various scripts, and also any relationships that exist between them (such as needing to run the `build` script before the `test`, for example).

Expand All @@ -92,7 +92,7 @@ By default the modern task runner powered by Nx will automatically load `.env` f

For more details about what `.env` files will be loaded by default please see: https://nx.dev/recipes/environment-variables/define-environment-variables

### Obselete options in `lerna run` with the new task-runner implementation
### Obsolete options in `lerna run` with the new task-runner implementation

There are certain legacy options for `lerna run` which are no longer applicable to the modern task-runner. Please see full details about those flags, and the reason behind their obselence, here:

Expand Down
2 changes: 1 addition & 1 deletion README.md
Expand Up @@ -30,7 +30,7 @@ Lerna is a fast, modern build system for managing and publishing multiple JavaSc
<a href="">
<img alt="Semantic Release" src="https://img.shields.io/badge/%20%20%F0%9F%93%A6%F0%9F%9A%80-semantic--release-e10079.svg?style=flat" />
</a>
<a href="http://commitizen.github.io/cz-cli/">
<a href="https://commitizen.github.io/cz-cli/">
<img alt="Commitizen friendly" src="https://img.shields.io/badge/commitizen-friendly-brightgreen.svg">
</a>
<a href="https://go.nrwl.io/join-slack">
Expand Down
2 changes: 1 addition & 1 deletion e2e/version/src/conventional-commits.spec.ts
Expand Up @@ -360,7 +360,7 @@ describe("lerna-version-conventional-commits", () => {
// Initial versioning with two packages created
const output1 = await fixture.lerna("version --conventional-commits -y", { silenceError: true });

// NOTE: In the independent case, lerna started with verion 1.0.0 as its assumed baseline (not 0.0.0 as in the fixed mode case)
// NOTE: In the independent case, lerna started with version 1.0.0 as its assumed baseline (not 0.0.0 as in the fixed mode case)
expect(output1.combinedOutput).toMatchInlineSnapshot(`
lerna notice cli v999.9.9-e2e.0
lerna info versioning independent
Expand Down
2 changes: 1 addition & 1 deletion libs/core/src/lib/collect-updates/index.spec.ts
Expand Up @@ -146,7 +146,7 @@ describe("collectUpdates()", () => {
]);
});

it("skips change detection when current revison is already released", () => {
it("skips change detection when current revision is already released", () => {
changedPackages.add("package-dag-1");

describeRefSync.mockReturnValueOnce({
Expand Down
2 changes: 1 addition & 1 deletion libs/core/src/lib/command/index.ts
Expand Up @@ -56,7 +56,7 @@ export class Command {
chain = chain.then(() => this.configureOptions());
chain = chain.then(() => this.configureProperties());
chain = chain.then(() => this.configureLogging());
// For the special "repair" command we want to intitialize everything but don't want to run validations as that will end up becoming cyclical
// For the special "repair" command we want to initialize everything but don't want to run validations as that will end up becoming cyclical
if (!skipValidations) {
chain = chain.then(() => this.runValidations());
}
Expand Down
2 changes: 1 addition & 1 deletion libs/core/src/lib/otplease.test.ts
Expand Up @@ -94,7 +94,7 @@ describe("otplease", () => {
otpCache.otp = "654321";
});

// start intial otplease call, 'catch' will happen in next turn *after* the cache is set.
// start initial otplease call, 'catch' will happen in next turn *after* the cache is set.
const result = await otplease(fn, {}, otpCache);
expect(fn).toHaveBeenCalledTimes(2);
expect(promptTextInput).not.toHaveBeenCalled();
Expand Down
2 changes: 1 addition & 1 deletion libs/core/src/lib/otplease.ts
Expand Up @@ -69,7 +69,7 @@ function attempt<T extends Record<string, unknown>>(
return attempt(fn, { ...opts, ...otpCache }, otpCache);
}
// only allow one getOneTimePassword attempt at a time to reuse the value
// from the preceeding prompt
// from the preceding prompt
return semaphore.wait().then(() => {
// check the cache again in case a previous waiter already updated it.
if (otpCache != null && otpCache.otp != null && otpCache.otp !== opts["otp"]) {
Expand Down

0 comments on commit 86f8021

Please sign in to comment.