refactor: Migrate to unambiguous promptSelectOne()

lerna · Dec 10, 2020 · 5d05d95 · 5d05d95
1 parent e9237f3
commit 5d05d95
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/commands/version/__tests__/prompt-version.test.js b/commands/version/__tests__/prompt-version.test.js
@@ -17,7 +17,7 @@ describe("select", () => {
         version: "1.2.3",
       });
 
-      expect(prompt.select).toHaveBeenLastCalledWith(
+      expect(prompt.promptSelectOne).toHaveBeenLastCalledWith(
         "Select a new version (currently 1.2.3)",
         expect.objectContaining({
           choices: expect.any(Array),
@@ -31,7 +31,7 @@ describe("select", () => {
         name: "my-package",
       });
 
-      expect(prompt.select).toHaveBeenLastCalledWith(
+      expect(prompt.promptSelectOne).toHaveBeenLastCalledWith(
         "Select a new version for my-package (currently 3.2.1)",
         expect.any(Object)
       );

diff --git a/commands/version/__tests__/version-bump.test.js b/commands/version/__tests__/version-bump.test.js
@@ -23,7 +23,7 @@ describe("version bump", () => {
     const testDir = await initFixture("normal");
     await lernaVersion(testDir)("1.0.1-beta.25");
 
-    expect(PromptUtilities.select).not.toHaveBeenCalled();
+    expect(PromptUtilities.promptSelectOne).not.toHaveBeenCalled();
 
     const message = await getCommitMessage(testDir);
     expect(message).toBe("v1.0.1-beta.25");
@@ -56,7 +56,7 @@ describe("version bump", () => {
     const testDir = await initFixture("normal");
     await lernaVersion(testDir)("minor");
 
-    expect(PromptUtilities.select).not.toHaveBeenCalled();
+    expect(PromptUtilities.promptSelectOne).not.toHaveBeenCalled();
 
     const message = await getCommitMessage(testDir);
     expect(message).toBe("v1.1.0");

diff --git a/commands/version/__tests__/version-command.test.js b/commands/version/__tests__/version-command.test.js
@@ -56,7 +56,7 @@ describe("VersionCommand", () => {
 
       expect(checkWorkingTree).toHaveBeenCalled();
 
-      expect(PromptUtilities.select.mock.calls).toMatchSnapshot("prompt");
+      expect(PromptUtilities.promptSelectOne.mock.calls).toMatchSnapshot("prompt");
       expect(PromptUtilities.confirm).toHaveBeenLastCalledWith(
         "Are you sure you want to create these versions?"
       );
@@ -454,7 +454,7 @@ describe("VersionCommand", () => {
       const testDir = await initFixture("normal");
       await lernaVersion(testDir)("--yes", "patch");
 
-      expect(PromptUtilities.select).not.toHaveBeenCalled();
+      expect(PromptUtilities.promptSelectOne).not.toHaveBeenCalled();
       expect(PromptUtilities.confirm).not.toHaveBeenCalled();
 
       const message = await getCommitMessage(testDir);
@@ -748,7 +748,7 @@ describe("VersionCommand", () => {
       const testDir = await initFixture("normal");
       await lernaVersion(testDir)("--include-merged-tags", "--yes", "patch");
 
-      expect(PromptUtilities.select).not.toHaveBeenCalled();
+      expect(PromptUtilities.promptSelectOne).not.toHaveBeenCalled();
       expect(PromptUtilities.confirm).not.toHaveBeenCalled();
 
       const message = await getCommitMessage(testDir);

diff --git a/commands/version/lib/prompt-version.js b/commands/version/lib/prompt-version.js
@@ -31,7 +31,7 @@ function promptVersion(currentVersion, name, prereleaseId) {
 
   const message = `Select a new version ${name ? `for ${name} ` : ""}(currently ${currentVersion})`;
 
-  return PromptUtilities.select(message, {
+  return PromptUtilities.promptSelectOne(message, {
     choices: [
       { value: patch, name: `Patch (${patch})` },
       { value: minor, name: `Minor (${minor})` },