New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cockroachdb): add support upsert #4767
Conversation
This also needs documentation at https://github.com/knex/documentation |
How do I indicate in the documentation that this implementation is for CockroachDB only |
@intech Just add it in text description that it only works with crdb. |
Done |
Could you also please update TS types? |
@kibertoad I think I need your help with this |
@intech Sure, what can I help with? |
With linting errors for TS in tests. I have little experience with TS |
@kibertoad Nice, thx! Now I saw my mistake. |
Created issue to incrementally support Upsert across dialects: #4769 |
Thank you for your contribution! |
Co-authored-by: Igor Savin <iselwin@gmail.com>
Add support
upsert()
for CockroachDBDocs: upsert
Related: #2002