Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cockroachdb): add support upsert #4767

Merged
merged 11 commits into from Oct 24, 2021
Merged

feat(cockroachdb): add support upsert #4767

merged 11 commits into from Oct 24, 2021

Conversation

intech
Copy link
Contributor

@intech intech commented Oct 22, 2021

Add support upsert() for CockroachDB
Docs: upsert
Related: #2002

@kibertoad
Copy link
Collaborator

This also needs documentation at https://github.com/knex/documentation

@intech
Copy link
Contributor Author

intech commented Oct 22, 2021

This also needs documentation at https://github.com/knex/documentation

How do I indicate in the documentation that this implementation is for CockroachDB only

@kibertoad
Copy link
Collaborator

@intech Just add it in text description that it only works with crdb.

@intech
Copy link
Contributor Author

intech commented Oct 23, 2021

@intech Just add it in text description that it only works with crdb.

Done

@kibertoad
Copy link
Collaborator

Could you also please update TS types?

@intech
Copy link
Contributor Author

intech commented Oct 24, 2021

@kibertoad I think I need your help with this

@kibertoad
Copy link
Collaborator

@intech Sure, what can I help with?

@intech
Copy link
Contributor Author

intech commented Oct 24, 2021

@intech Sure, what can I help with?

With linting errors for TS in tests. I have little experience with TS

@intech
Copy link
Contributor Author

intech commented Oct 24, 2021

@kibertoad Nice, thx! Now I saw my mistake.

@kibertoad
Copy link
Collaborator

Created issue to incrementally support Upsert across dialects: #4769

@kibertoad kibertoad merged commit 6840d3f into knex:master Oct 24, 2021
@kibertoad
Copy link
Collaborator

Thank you for your contribution!

OlivierCavadenti pushed a commit to AbeonaPascha/knex that referenced this pull request Nov 4, 2021
Co-authored-by: Igor Savin <iselwin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants