mssql: Support table.primary, table.unique variant with options object #4710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremy-w
force-pushed
the
jsherman/mssql/fix-pk-constraint-name-generation
branch
from
624b38a
to
3e006ea
Compare
|
Apparently mysql & sqlite3 also were not updated to cope with the non-deprecated flavor. 🤔 |
mssql:
- Add support for table.primary(col, {constraintName})
- Add support for table.unique(col, {indexName})
jeremy-w
force-pushed
the
jsherman/mssql/fix-pk-constraint-name-generation
branch
from
3e006ea
to
e0d5b7b
Compare
kibertoad
approved these changes
Oct 10, 2021
|
Thank you! |
rustyconover
pushed a commit
to rustyconover/knex
that referenced
this pull request
Oct 18, 2021
OlivierCavadenti
pushed a commit
to AbeonaPascha/knex
that referenced
this pull request
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the mssql driver only supported
table.primary(cols, 'literalString'), and likewise fortable.unique. But the TypeScript types have that variant marked deprecated, which pushed you to try to writetable.primary(cols, {constraintName: 'literalString'})/table.unique(cols, {indexName: 'literalString'}), which promptly failed at runtime.Now, both variants work. If a
deferrableconfiguration is provided other than'not deferred', a warning will be omitted, but schema building will proceed.