fix onDelete/onUpdate for ColumnBuilder

[maximelkin]

fixes #4620
This breaks wrong code, when onDelete/onUpdate called not in context of foreign constraints.
But also breaks valid code, i.e.:

table.integer('num').references('non_exist.id').index('num_idx').onDelete('CASCADE');

(index() method return ColumnBuilder interface, not ReferencingColumnBuilder)

This probably could be fixed with rewriting code to extending previous interface with new methods instead of current approach, idk is it worth it?

@lorefnon

[kibertoad]

@zeotuan Any thoughts?

[zeotuan]

if we change the index(indexName?:string): ColumnBuilder to index(indexName?:string): ReferrencingColumnBuilder It would temporarily solve this problem right? But i am not sure if it would be a good solution though. @maximelkin @lorefnon what do you guys think?

[maximelkin]

Now this is more close to knex js implementation, but this is kinda hack.

[maximelkin]

@zeotuan can you check PR?

[kibertoad]

@zeotuan Ping?

[zeotuan]

I tried this code and got the same result as your @maximelkin. What is the advantage of your compared to this?

type ReferencingColumnBuilder = {
    [K in keyof ColumnBuilder]: (...args) =>  ReferencingColumnBuilder
  } & {
    inTable(tableName: string): ReferencingColumnBuilder;
    deferrable(type: deferrableType): ReferencingColumnBuilder;
    withKeyName(keyName: string): ReferencingColumnBuilder;
    onDelete(command: string): ReferencingColumnBuilder;
    onUpdate(command: string): ReferencingColumnBuilder;
  };

Also if you believe your solution is better than the one above can you make it this way so it's easier to understand

type ReferencingColumnBuilder = {
    [K in keyof ColumnBuilder]: ColumnBuilder[K] extends (...args: infer TArgs) => any 
      ? (...args: TArgs) => ReferencingColumnBuilder 
      : ColumnBuilder[K];
  } & {
    inTable(tableName: string): ReferencingColumnBuilder;
    deferrable(type: deferrableType): ReferencingColumnBuilder;
    withKeyName(keyName: string): ReferencingColumnBuilder;
    onDelete(command: string): ReferencingColumnBuilder;
    onUpdate(command: string): ReferencingColumnBuilder;
  };

[maximelkin]

@zeotuan first variant erases args types

[zeotuan]

@maximelkin You are right! What do you think about this one?

 // patched ColumnBuilder methods to return ReferencingColumnBuilder with new methods
  // relies on ColumnBuilder returning only ColumnBuilder
  type ReferencingColumnBuilder = {
    [K in keyof ColumnBuilder]: (...arg: Parameters<ColumnBuilder[K]> ) => ReferencingColumnBuilder
  } & {
    inTable(tableName: string): ReferencingColumnBuilder;
    deferrable(type: deferrableType): ReferencingColumnBuilder;
    withKeyName(keyName: string): ReferencingColumnBuilder;
    onDelete(command: string): ReferencingColumnBuilder;
    onUpdate(command: string): ReferencingColumnBuilder;
  };

[maximelkin]

@zeotuan this is nice, updated PR