Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mssql): Support comments as MS_Description properties [fixes #4204] #4632

Conversation

jeremy-w
Copy link
Contributor

@jeremy-w jeremy-w commented Aug 21, 2021

Table and column comments are now compiled into MS_Description
extended properties.

[fixes #4204]

Table and column comments are now compiled into MS_Description
extended properties.

[fixes knex#4204]
@kibertoad kibertoad merged commit 5ac4224 into knex:master Aug 21, 2021
@alexanderankin
Copy link

@jeremy-w awesome! nice job

@jeremy-w jeremy-w deleted the jsherman/mssql/support-table-and-column-comments-4204 branch August 22, 2021 20:08
OlivierCavadenti pushed a commit to AbeonaPascha/knex that referenced this pull request Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MSSQL Comments in SchemaBuilder are not used, using exec sp_updateextendedproperty in lieu of comments
3 participants