Add support for mysql/mariadb-client JSON parameters in connectionURIs

[petetnt]

This PR fixes #4628 by adding support for parsing JSON-like URL parameters for mysql/mariadb-clients (mysqljs/mysql, node-mysql2)

[kibertoad]

Thanks! Can you also add a very simple integration test that would ensure MySQL actually works when such connection params are passed to it?

[petetnt]

Hi @kibertoad!

Sorry for the late response, busy week... I added integration tests in petetnt@550eaab

Added them to integration2/mysql2.spec.js as it seemed the most appropriate place, but don't know if it is the correct place.

As SSL settings require quite a lot of effort to get running locally, I opted for using rejectUnauthorized as a test case (documented in https://github.com/mysqljs/mysql#ssl-options). Additionally I added a test to ensure that passing a string as the profile still works (ssl=Amazon RDS would also work, but it will throw with self signed certificates in signature chain error when running regardless).

[kibertoad]

@petetnt CI is failing, unfortunately.

[petetnt]

Dang, Ill look into that on monday! Tests were passing locally, but only ran a subset of them as installing stuff on M1 Macs was a bit of a pain :)

…

On 28. Aug 2021, at 22.04, Igor Savin ***@***.***> wrote:  @petetnt CI is failing, unfortunately. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

[kibertoad]

@petetnt There is docker-compose config available for all the dbs, check scripts in package.json

[petetnt]

I was using that, I meant that eg. mysql doesn't have an ARM64 build at all, so one needs to specify platform: linux/x86_64 on the docker-compose file etc. to pull those images and run them with Rosetta and so on.

The failing test is

  Failed Tests: There were 2 failures

    #4628, supports mysql / mariadb client JSON parameters

      ✖ should be loosely deeply equivalent
      ✖ should be loosely deeply equivalent

I think that the prettier fixing removing those "extra" /s as unnecessary escapes broke the equivalency checks there, should be an easy fix when I get pack to my computer 👍

[petetnt]

The actual issue was port 0000 being parsed to 0, which was fixed in 4fda93e :)