fix: use sys info function instead of connection db name #4623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you add test for this? |
|
@kibertoad sorry, I updated affected tests. There were already tests covering this, not only including the two i updated. |
|
@rijkvanzanten Does this make sense for you? |
|
Yes it does! Like @sifer mentioned, it is a bit of an edge case, but you can in fact tell PgBouncer to expose a different database name than the one used in the actual database, effectively creating an alias for the database. By relying on the connection config in knex, it'll use the name of the alias in the SQL query instead of the name of the actual database, which will fail. It does make me wonder: does the same problem occur with other databases and load balancer combinations? |
kibertoad
approved these changes
Aug 20, 2021
|
Released in 0.95.11 |
OlivierCavadenti
pushed a commit
to AbeonaPascha/knex
that referenced
this pull request
Nov 4, 2021
Co-authored-by: Maximilian-Albin Ekström <maximilian-albin.ekstrom@instabox.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an edge case when getting proxied by for example PgBouncer that could result in client connection not being the same as the current database.
Using current_database() seems like a safer approach.