Fixing posgres datetime and timestamp column created with wrong format

[zeotuan]

• Why:
  See issue Not passing useTz in datetime column creation results in "datetime without timezone #4577

• How:

1. Change default useTz option of datetime and timezone to true in pg column compiler.
2. Adding additional test to check when empty option object or option object wihout timezone is passed.

[kibertoad]

Doesn't this change default values and hence is a breaking change?

[kibertoad]

Isn't this still a breaking change, as it will invert values set by users already?

[zeotuan]

@kibertoad sorry the naming of variables was bad. Yeah i think so. I can change it so that it is not a breaking change anymore. I don't know why but when i was doing it i thought it look cleaner since postgres has tz true as default

[kibertoad]

It is cleaner, yes, just a bit too late to change it, would require a semver major and still likely to break stuff for people who don't read docs.

[armandAkop]

Maybe I'm missing some context since I'm not familiar with the code base, but wouldn't passing false here result in timestamp WITHOUT timezone? Why does it seem inverted?

[zeotuan]

Passing false there would result in timestamptz because :

• This is the original design which can accept:

  • 2 param: withoutTz=false, precision(this is not documented could be because it would cause confusion)
  • an option object {useTz: boolean, precision: number}(documented)
    
    you can see that it actually invert what users pass in if not passed as option object

• And this is the original test for timestamp() which do the same thing as datetime()
  

The test that you see is just the one i added for datetime. I did changed it to withTz so it does not seem inverted anymore. But as @kibertoad said, it will cause breaking change for people who had already done it the original way so i just added the bug fix and sometest without changing the parameter. Maybe we could request this as feature for future update because i agree that it is not intuiitive.

[zeotuan]

@kibertoad I changed it so it fixed the bug without making breaking changes. Is there any other change that i need to do?

[kibertoad]

Thank you!