Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nguymin4/improve types #4576

Merged
merged 2 commits into from Jul 20, 2021
Merged

Conversation

nguymin4
Copy link
Contributor

@nguymin4 nguymin4 commented Jul 16, 2021

  • Improve type support for analytic functions (See tests for more detail)
  • Extract common interfaces for tsd

Important note: I intended to migrate analytic-function-types testing to tsd but I found a problem with the tsd library
For example

  expectType<Pick<User, 'id'>>(
    await knex<User>('users').select('foo')
  );

I expect this test fails but the test somehow passes. I think this is a tsd issue. Thus we need to be more careful before migrating from dtslint to tsd. I will try to debug this if I have time but in my opinion dtslint is still doing a good job for us

@kibertoad kibertoad merged commit c9a5548 into knex:master Jul 20, 2021
@nguymin4 nguymin4 deleted the nguymin4/improve-types branch July 20, 2021 22:43
@kibertoad
Copy link
Collaborator

Released in 0.95.8

OlivierCavadenti pushed a commit to AbeonaPascha/knex that referenced this pull request Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants