Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: export client class from knex namespace #4479

Merged
merged 3 commits into from
May 11, 2021
Merged

fix: export client class from knex namespace #4479

merged 3 commits into from
May 11, 2021

Conversation

KristjanTammekivi
Copy link
Contributor

Fixes #4475

@kibertoad
Copy link
Collaborator

@KristjanTammekivi Thank you! Can you also add tsd test for this?

@KristjanTammekivi
Copy link
Contributor Author

Good point, found a mistake thanks to it

@kibertoad kibertoad merged commit 08cb69d into knex:master May 11, 2021
@kibertoad
Copy link
Collaborator

Much appreciated. Will do my best to publish new version today.

@felixmosh
Copy link
Contributor

@KristjanTammekivi thank you 🙏🏼

@Mr0grog Mr0grog mentioned this pull request Jul 29, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kibertoad kibertoad kibertoad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typescript: Can make a custom Client work with Config types
3 participants
@KristjanTammekivi @kibertoad @felixmosh