Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .cjs extension to Seeder.js to support Node ESM (#4381) #4382

Merged
merged 1 commit into from May 11, 2021

Conversation

adamlove01
Copy link
Contributor

Added '.cjs' to the list of supported extensions for seed files in the Seeder.js setConfig(config) {} function.

This will allow users to run seeds with Knex in CommonJS mode within a Node project that has has ESM support.

@kibertoad kibertoad merged commit 234eddd into knex:master May 11, 2021
@kibertoad
Copy link
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants