Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add dropForeign arg type for single column #4363

Merged
merged 2 commits into from Mar 25, 2021
Merged

add dropForeign arg type for single column #4363

merged 2 commits into from Mar 25, 2021

Conversation

capaj
Copy link
Contributor

@capaj capaj commented Mar 10, 2021

No description provided.

@kibertoad
Copy link
Collaborator

@capaj

  types/index.d.ts:1862:29
  ✖  1862:29  readonly type modifier is only permitted on array and tuple literal types.

@capaj
Copy link
Contributor Author

capaj commented Mar 25, 2021

@kibertoad should be good now

@kibertoad kibertoad merged commit fab2ed6 into knex:master Mar 25, 2021
@kibertoad
Copy link
Collaborator

Thanks!

@capaj capaj deleted the patch-6 branch March 25, 2021 09:25
@kibertoad
Copy link
Collaborator

Released in 0.95.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kibertoad kibertoad kibertoad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@capaj @kibertoad