Update mixin.js #995
Merged
Update mixin.js #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This issue fixes a bug that happens when a SFC has a <i18n> block aswell as a i18n configuration in the Vue Component options. Previously, the i18n configuration from the Vue Component options would be overridden by the <i18n> block; Using this new behaviour, the <i18n> block and the i18n configuration from the Vue Component options are merged. This also helps to provide mixin support, since now a consumer of this library can have a SFC as a parent component, which uses a Vue mixin, and using a custom vue optionMergeStrategy, full mixin support can be achieved from consumer side.
|
Thank you for your PR! |
|
Hi kazupon, thank you for recognizing the PR :) |
|
@ferencbeutel4711 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that happens when a SFC has a <i18n> block aswell as a i18n configuration in the Vue Component options.
Previously, the i18n configuration from the Vue Component options would be overridden by the <i18n> block; Using this new behaviour, the <i18n> block and the i18n configuration from the Vue Component options are merged.
This also helps to provide mixin support, since now a consumer of this library can have a SFC as a parent component, which uses a Vue mixin, and using a custom vue optionMergeStrategy, full mixin support can be achieved from consumer side.