Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix in index.js: wrong if condition in fetchChoice #1003

Merged
merged 1 commit into from Oct 6, 2020

Conversation

cimchd
Copy link
Contributor

@cimchd cimchd commented Sep 15, 2020

Wrong if condition, it should be or instad of and. Otherwise the second part of the if condition makes no sense.

Wrong if condition, it should be or instad of and. Otherwise the second part of the if conditions makes no sense.
@cimchd cimchd changed the title Update index.js Bugfix in index.js: wrong if condition in fetchChoice Sep 15, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #1003 into v8.x will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             v8.x    #1003   +/-   ##
=======================================
  Coverage   96.46%   96.46%           
=======================================
  Files          10       10           
  Lines         904      904           
=======================================
  Hits          872      872           
  Misses         32       32           
Impacted Files Coverage Δ
src/index.js 97.82% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3debac...3514ab3. Read the comment docs.

Copy link
Owner

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kazupon kazupon added the Type: Bug Bug or Bug fixes label Oct 6, 2020
@kazupon kazupon merged commit ce45265 into kazupon:v8.x Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged Type: Bug Bug or Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants