Fix radio/checkbox to not fire events when disconnected

jsdom · Mar 28, 2021 · fdf97d8 · fdf97d8
1 parent 761d8cc
commit fdf97d8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/lib/jsdom/living/nodes/HTMLInputElement-impl.js b/lib/jsdom/living/nodes/HTMLInputElement-impl.js
@@ -196,8 +196,10 @@ class HTMLInputElementImpl extends HTMLElementImpl {
     const { form } = this;
 
     if (this.type === "checkbox" || (this.type === "radio" && !this._preCheckedRadioState)) {
-      fireAnEvent("input", this, undefined, { bubbles: true });
-      fireAnEvent("change", this, undefined, { bubbles: true });
+      if (this.isConnected) {
+        fireAnEvent("input", this, undefined, { bubbles: true });
+        fireAnEvent("change", this, undefined, { bubbles: true });
+      }
     } else if (form && this.type === "submit") {
       form._doSubmit();
     } else if (form && this.type === "reset") {

diff --git a/test/web-platform-tests/to-run.yaml b/test/web-platform-tests/to-run.yaml
@@ -165,9 +165,6 @@ DIR: dom/events
 
 AddEventListenerOptions-signal.any.html: [fail, Not implemented]
 Event-dispatch-click.tentative.html: [fail, Test is wrong, https://github.com/web-platform-tests/wpt/issues/27819]
-Event-dispatch-detached-input-and-change.html: [fail,
-  Need implement connected and use it in https://github.com/jsdom/jsdom/blob/master/lib/jsdom/living/nodes/HTMLInputElement-impl.js#L199
-  See https://html.spec.whatwg.org/multipage/input.html#checkbox-state-(type=checkbox)]
 Event-isTrusted.any.html: [fail, Unknown]
 Event-timestamp-high-resolution.html: [fail, Not implemented]
 EventListener-incumbent-global-1.sub.html: [timeout, Multi-globals]