Add ParentNode.replaceChildren() (#3176)

Fixes #3102.
jsdom · Apr 15, 2021 · 04f6c13 · 04f6c13
1 parent e4c4004
commit 04f6c13
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/lib/jsdom/living/nodes/ParentNode-impl.js b/lib/jsdom/living/nodes/ParentNode-impl.js
@@ -55,6 +55,12 @@ class ParentNodeImpl {
     this._append(convertNodesIntoNode(this._ownerDocument, nodes));
   }
 
+  replaceChildren(...nodes) {
+    const node = convertNodesIntoNode(this._ownerDocument, nodes);
+    this._preInsertValidity(node, null);
+    this._replaceAll(node);
+  }
+
   querySelector(selectors) {
     if (shouldAlwaysSelectNothing(this)) {
       return null;

diff --git a/lib/jsdom/living/nodes/ParentNode.webidl b/lib/jsdom/living/nodes/ParentNode.webidl
@@ -7,6 +7,7 @@ interface mixin ParentNode {
 
   [CEReactions, Unscopable] void prepend((Node or DOMString)... nodes);
   [CEReactions, Unscopable] void append((Node or DOMString)... nodes);
+  [CEReactions, Unscopable] undefined replaceChildren((Node or DOMString)... nodes);
 
   Element? querySelector(DOMString selectors);
   [NewObject] NodeList querySelectorAll(DOMString selectors);

diff --git a/test/web-platform-tests/to-run.yaml b/test/web-platform-tests/to-run.yaml
@@ -222,7 +222,6 @@ Node-cloneNode.html: [timeout, Often takes more than 70 seconds to pass, https:/
 Node-isConnected.html: [fail, Last two tests with <iframe> are failing]
 ParentNode-querySelector-All-xht.xht: [fail, ::slotted() pseudo-class is not supported]
 ParentNode-querySelector-All.html: [fail, ::slotted() pseudo-class is not supported]
-ParentNode-replaceChildren.html: [fail, Not implemented]
 ProcessingInstruction-escapes-1.xhtml: [fail, Unknown]
 adoption.window.html: [fail, "We do not implement https://github.com/whatwg/dom/pull/754 due to https://github.com/whatwg/dom/issues/813"]
 aria-attribute-reflection.tentative.html: [fail, Unknown]