revert: "feat(validationSchema): support yup transforms in validate &…

… submit (#3796)" (#3815)

Fixes #3809

Will consider this for a future major release.

This reverts commit 2f53b70.

.changeset/thick-radios-clap.md

@@ -0,0 +1,5 @@
+---
+'formik': patch
+---
+
+Revert Yup transform support for the time being, this may be re-introduced in a future release under an opt-in prop.

packages/formik/src/Formik.tsx

@@ -218,7 +218,10 @@ export function useFormik<Values extends FormikValues = FormikValues>({
    */
   const runValidationSchema = React.useCallback(
     (values: Values, field?: string): Promise<FormikErrors<Values>> => {
-      const schema = getValidationSchema(props.validationSchema);
+      const validationSchema = props.validationSchema;
+      const schema = isFunction(validationSchema)
+        ? validationSchema(field)
+        : validationSchema;
       const promise =
         field && schema.validateAt
           ? schema.validateAt(field, values)
@@ -842,11 +845,7 @@ export function useFormik<Values extends FormikValues = FormikValues>({
   };
 
   const executeSubmit = useEventCallback(() => {
-    const schema = getValidationSchema(props.validationSchema);
-    const actualizedValues =
-      schema && schema.cast ? schema.cast(state.values) : state.values;
-
-    return onSubmit(actualizedValues, imperativeMethods);
+    return onSubmit(state.values, imperativeMethods);
   });
 
   const handleReset = useEventCallback(e => {
@@ -1024,16 +1023,6 @@ export function Formik<
   );
 }
 
-function getValidationSchema<Values extends FormikValues = FormikValues>(
-  validationSchema?: FormikConfig<Values>['validationSchema']
-) {
-  if (!validationSchema) {
-    return;
-  }
-
-  return isFunction(validationSchema) ? validationSchema() : validationSchema;
-}
-
 function warnAboutMissingIdentifier({
   htmlContent,
   documentationAnchorLink,

packages/formik/test/Formik.test.tsx

@@ -1435,8 +1435,8 @@ describe('<Formik>', () => {
     await act(async () => {
       try {
         await getProps().validateForm();
-      } catch (err) {
-        caughtError = (err as Yup.ValidationError).message;
+      } catch ({ message }) {
+        caughtError = message;
       }
     });
 
@@ -1450,68 +1450,4 @@ describe('<Formik>', () => {
 
     expect(innerRef.current).toEqual(getProps());
   });
-
-  it('transforms in yup schema are applied on validation', async () => {
-    const validationSchema = Yup.object({
-      users: Yup.array().of(
-        Yup.object({
-          firstName: Yup.string()
-            .transform(currentValue =>
-              currentValue.split('').reverse().join('')
-            )
-            // @ts-expect-error incorrect typing for second arg
-            .oneOf(['foo'], x => x.value),
-        })
-      ),
-    });
-
-    const { getProps } = renderFormik({
-      initialValues: { users: [{ firstName: 'foo' }] },
-      validationSchema,
-    });
-
-    await act(async () => {
-      await getProps().validateForm();
-
-      expect(getProps().errors).toEqual({
-        users: [
-          {
-            // the transform reverses "foo" to "oof", which then fails the `oneOf` assertion
-            firstName: 'oof',
-          },
-        ],
-      });
-    });
-  });
-
-  it('transforms in yup schema are applied on submit', async () => {
-    const validationSchema = Yup.object({
-      users: Yup.array().of(
-        Yup.object({
-          firstName: Yup.string().transform(currentValue =>
-            currentValue.split('').reverse().join('')
-          ),
-        })
-      ),
-    });
-
-    const spy = jest.fn();
-
-    const { getProps } = renderFormik({
-      initialValues: { users: [{ firstName: 'foo' }] },
-      onSubmit: spy,
-      validationSchema,
-    });
-
-    await act(async () => {
-      await getProps().submitForm();
-
-      expect(spy).toHaveBeenCalledWith(
-        {
-          users: [{ firstName: 'oof' }],
-        },
-        expect.anything()
-      );
-    });
-  });
 });

packages/formik/test/withFormik.test.tsx

@@ -134,18 +134,15 @@ describe('withFormik()', () => {
   });
 
   it('calls validationSchema', async () => {
-    const validationSchema = Yup.object();
-
-    jest.spyOn(validationSchema, 'validate');
-
+    const validate = jest.fn(() => Promise.resolve());
     const { getProps } = renderWithFormik({
-      validationSchema,
+      validationSchema: { validate },
     });
 
     act(() => {
       getProps().submitForm();
     });
-    await waitFor(() => expect(validationSchema.validate).toHaveBeenCalled());
+    await waitFor(() => expect(validate).toHaveBeenCalled());
   });
 
   it('calls validationSchema function with props', async () => {