fix: Add favicon to html report (#493)

istanbuljs · Nov 24, 2019 · 5afe203 · 5afe203
1 parent a01a2b8
commit 5afe203
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/packages/istanbul-reports/lib/html/assets/favicon.png b/packages/istanbul-reports/lib/html/assets/favicon.png
diff --git a/packages/istanbul-reports/lib/html/index.js b/packages/istanbul-reports/lib/html/index.js
@@ -16,7 +16,10 @@ function htmlHead(details) {
     <meta charset="utf-8" />
     <link rel="stylesheet" href="${html.escape(details.prettify.css)}" />
     <link rel="stylesheet" href="${html.escape(details.base.css)}" />
-    <meta name="viewport" content="width=device-width, initial-scale=1">
+    <link rel="shortcut icon" type="image/x-icon" href="${html.escape(
+        details.favicon
+    )}" />
+    <meta name="viewport" content="width=device-width, initial-scale=1" />
     <style type='text/css'>
         .coverage-summary .sorter {
             background-image: url(${html.escape(details.sorter.image)});
@@ -303,6 +306,7 @@ class HtmlReport extends ReportBase {
             js: linkMapper.assetPath(node, 'prettify.js'),
             css: linkMapper.assetPath(node, 'prettify.css')
         };
+        templateData.favicon = linkMapper.assetPath(node, 'favicon.png');
     }
 
     getTemplateData() {

diff --git a/packages/istanbul-reports/test/html-spa/index.js b/packages/istanbul-reports/test/html-spa/index.js
@@ -83,6 +83,15 @@ describe('html-spa', () => {
                     dest: './block-navigation.js',
                     header: '/* eslint-disable */\n'
                 },
+                {
+                    dest: './favicon.png',
+                    header: undefined,
+                    source: path.join(
+                        __dirname,
+                        '/../../lib/html/assets/favicon.png'
+                    ),
+                    type: 'copy'
+                },
                 {
                     type: 'copy',
                     source: path.join(