Generate fixtures more effectively, with -O instead of eval

isaacs · Jul 5, 2015 · 0a2b519 · 0a2b519
1 parent f96190b
commit 0a2b519
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1,5 +1,4 @@
 .*.swp
-test/a/
 node_modules/*
 v8.log
 profile.txt

diff --git a/test/00-setup.js b/test/00-setup.js
@@ -107,12 +107,14 @@ var fs = require("fs")
 
 globs.forEach(function (pattern) {
   tap.test("generate fixture " + pattern, function (t) {
-    var cmd = "shopt -s globstar && " +
-              "shopt -s extglob && " +
-              "shopt -s nullglob && " +
-              // "shopt >&2; " +
-              "eval \'for i in " + pattern + "; do echo $i; done\'"
-    var cp = spawn("bash", ["-c", cmd], { cwd: fixtureDir })
+    var opts = [
+      "-O", "globstar",
+      "-O", "extglob",
+      "-O", "nullglob",
+      "-c",
+      "for i in " + pattern + "; do echo $i; done"
+    ]
+    var cp = spawn("bash", opts, { cwd: fixtureDir })
     var out = []
     cp.stdout.on("data", function (c) {
       out.push(c)