Improve type infererence for fromJS #1927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @KSXGitHub, I will release this next week probably. |
|
This has been released in 4.2.4. Thanks ! |
ntucker
reviewed
Feb 9, 2023
| @@ -5160,12 +5160,39 @@ declare namespace Immutable { | |||
| */ | |||
| function fromJS( | |||
| jsValue: unknown, | |||
| reviver?: ( | |||
| reviver: ( | |||
There was a problem hiding this comment.
No way this is correct - I never had problems skipping this argument in runtime.
There was a problem hiding this comment.
hi @ntucker . That's an overload for the definition right after. It does say :
- if the reviver method is set, then the return type is
Collection<unknown, unknown> - if the reviver is not set of undefined, then we can calculate the return type
There was a problem hiding this comment.
There was a problem hiding this comment.
This may very well be a bug with typescript, but I'm fairly certain you'd still be interested in supporting typescript versions less than 5.1
There was a problem hiding this comment.
Let's continue in #1935 to avoid multiplying conversation in different threads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally from KSXGitHub in #1617